Skip to content

[Demangler] Fix the name of float vector types in OldDemangler. #38079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2021
Merged

[Demangler] Fix the name of float vector types in OldDemangler. #38079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Demangling/OldDemangler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,7 +1877,7 @@ class OldDemangler {
return nullptr;
return Factory.createNode(
Node::Kind::BuiltinTypeName,
(DemanglerPrinter() << "Builtin.Vec" << elts << "xFloat"
(DemanglerPrinter() << "Builtin.Vec" << elts << "xFPIEEE"
<< size).str());
}
if (Mangled.nextIf('p'))
Expand Down
2 changes: 1 addition & 1 deletion lib/Demangling/OldRemangler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1178,7 +1178,7 @@ void Remangler::mangleBuiltinTypeName(Node *node) {
auto element = text.substr(splitIdx).substr(1);
if (element == "RawPointer") {
Buffer << 'p';
} else if (stripPrefix(element, "Float")) {
} else if (stripPrefix(element, "FPIEEE")) {
Buffer << 'f' << element << '_';
} else if (stripPrefix(element, "Int")) {
Buffer << 'i' << element << '_';
Expand Down
5 changes: 4 additions & 1 deletion test/Demangle/Inputs/manglings.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@ _TtBo ---> Builtin.NativeObject
_TtBp ---> Builtin.RawPointer
_TtBt ---> Builtin.SILToken
_TtBv4Bi8_ ---> Builtin.Vec4xInt8
_TtBv4Bf16_ ---> Builtin.Vec4xFloat16
_TtBv4Bf16_ ---> Builtin.Vec4xFPIEEE16
_TtBv4Bp ---> Builtin.Vec4xRawPointer
$sBi8_Bv4_ ---> Builtin.Vec4xInt8
$sBf16_Bv4_ ---> Builtin.Vec4xFPIEEE16
$sBpBv4_ ---> Builtin.Vec4xRawPointer
_TtSa ---> Swift.Array
_TtSb ---> Swift.Bool
_TtSc ---> Swift.UnicodeScalar
Expand Down
2 changes: 1 addition & 1 deletion test/Demangle/Inputs/simplified-manglings.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ _TtBO ---> Builtin.UnknownObject
_TtBo ---> Builtin.NativeObject
_TtBp ---> Builtin.RawPointer
_TtBv4Bi8_ ---> Builtin.Vec4xInt8
_TtBv4Bf16_ ---> Builtin.Vec4xFloat16
_TtBv4Bf16_ ---> Builtin.Vec4xFPIEEE16
_TtBv4Bp ---> Builtin.Vec4xRawPointer
_TtSa ---> Array
_TtSb ---> Bool
Expand Down