[SymbolGraph] do not synthesize subclass methods #38240
Merged
+11
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://80091081
|
@swift-ci Please smoke test |
franklinsch
reviewed
Jul 5, 2021
| public class Base { | ||
| public init() {} | ||
| public func foo() {} | ||
| } | ||
|
|
||
| public class Derived: Base { | ||
| // CHECK-DAG: "precise": "s:24SuperclassImplementation4BaseC3fooyyF::SYNTHESIZED::s:24SuperclassImplementation7DerivedC" | ||
| // CHECK-NOT: "precise": "s:24SuperclassImplementation4BaseC3fooyyF::SYNTHESIZED::s:24SuperclassImplementation7DerivedC" |
There was a problem hiding this comment.
Should we check that an inheritsFrom relationship exists instead?
There was a problem hiding this comment.
The inheritsFrom relationship is already tested in the "SymbolGraph/Relationships/InheritsFrom" test.
franklinsch
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://80091081
The current implementation for synthesizing subclass methods is inconsistent - it only works when the superclass is in the same module as the subclass. Since the �
inheritsFromrelation already implies that all the superclass methods are available to the subclass, this PR removes the generation of synthesized subclass methods from the symbol graph entirely.