Skip to content

[5.5] [SymbolGraph] do not synthesize subclass methods #38241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2021
Merged

[5.5] [SymbolGraph] do not synthesize subclass methods #38241

merged 1 commit into from
Jul 12, 2021

Conversation

QuietMisdreavus
Copy link
Contributor

Resolves rdar://80091081

This PR cherry-picks #38240 onto release/5.5.

Change Information

  • Description: This change removes synthesized subclass methods in favor of relying on the existing inheritsFrom relation to indicate that superclass methods exist on the subclass.
  • Scope of Issue: The symbol graph currently inconsistently synthesizes subclass methods; it doesn't synthesize them when the superclass is in a different module.
  • Risk: Low
  • Automated Testing: The lit test "SymbolGraph/Relationships/Synthesized/SuperclassImplementation" was updated to reflect the absence of these symbols.

@QuietMisdreavus QuietMisdreavus requested a review from a team as a code owner July 2, 2021 22:33
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please build toolchain macOS platform

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please build toolchain macOS platform

@QuietMisdreavus
Copy link
Contributor Author

Toolchain issue was fixed in e700ae3.

@swift-ci Please build toolchain macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Jul 6, 2021

macOS Toolchain
Download Toolchain
Git Sha - af2c5ca

Install command
tar -zxf swift-PR-38241-1045-osx.tar.gz --directory ~/

@QuietMisdreavus QuietMisdreavus merged commit 996ced8 into release/5.5 Jul 12, 2021
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/5.5/no-subclass-synth branch July 12, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklinsch franklinsch franklinsch approved these changes

@airspeedswift airspeedswift airspeedswift approved these changes

@bitjammer bitjammer Awaiting requested review from bitjammer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuietMisdreavus @swift-ci @franklinsch @airspeedswift