[5.5][CSGen] Don't apply one-way requirement to typed patterns #38346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typed patterns are represented by a name and a fixed contextual type, let's not use intermediary type variable and one-way constraint as its type because that variable would be bound right away to contextual type. Also setting type of a variable declaration to a type variable when contextual type is IUO doesn't play well with overload resolution because it expects an optional type for declarations with IUO attribute. Resolves: rdar://80271666 (cherry picked from commit 66b1149)
|
@swift-ci please clean test |
|
Build failed |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
|
@swift-ci please nominate |
DougGregor
approved these changes
Jul 13, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #38320
Typed patterns are represented by a name and a fixed contextual
type, let's not use intermediary type variable and one-way constraint
as its type because that variable would be bound right away to
contextual type. Also setting type of a variable declaration
to a type variable when contextual type is IUO doesn't play well
with overload resolution because it expects an optional type for
declarations with IUO attribute.
Scope: Declarations with implicit unwrapped optional type used as an explicit result type of a pattern in a body of a result builder.
Main Branch PR: [CSGen] Don't apply one-way requirement to typed patterns #38320
Resolves: rdar://80271666
Risk: Low
Reviewed By: @hborla
Testing: Regression tests added to the suite
Resolves: rdar://80271666
(cherry picked from commit 66b1149)