[CSGen] Don't apply one-way requirement to typed patterns #38320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
approved these changes
Jul 9, 2021
|
@swift-ci please smoke test |
Typed patterns are represented by a name and a fixed contextual type, let's not use intermediary type variable and one-way constraint as its type because that variable would be bound right away to contextual type. Also setting type of a variable declaration to a type variable when contextual type is IUO doesn't play well with overload resolution because it expects an optional type for declarations with IUO attribute. Resolves: rdar://80271666
|
@swift-ci please smoke test |
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jul 20, 2021
Follow-up for swiftlang#38320 Typed patterns no longer use an intermediary type variable, which created a problem for references to variables declared inside of a pattern because their types weren't recorded in constraint system. Resolves: rdar://80797176
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jul 20, 2021
Follow-up for swiftlang#38320 Typed patterns no longer use an intermediary type variable, which created a problem for references to variables declared inside of a pattern because their types weren't recorded in constraint system. Resolves: rdar://80797176
This was referenced Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typed patterns are represented by a name and a fixed contextual
type, let's not use intermediary type variable and one-way constraint
as its type because that variable would be bound right away to
contextual type. Also setting type of a variable declaration
to a type variable when contextual type is IUO doesn't play well
with overload resolution because it expects an optional type for
declarations with IUO attribute.
Resolves: rdar://80271666