[CSGen] Always record types of variables introduced by named patterns #38511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up for swiftlang#38320 Typed patterns no longer use an intermediary type variable, which created a problem for references to variables declared inside of a pattern because their types weren't recorded in constraint system. Resolves: rdar://80797176
|
@swift-ci please smoke test |
hborla
approved these changes
Jul 20, 2021
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please clean smoke test macOS platform |
|
Looks like this is actually causing more problems so I'm going to revert #38320 instead of now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #38320
Typed patterns no longer use an intermediary type variable,
which created a problem for references to variables declared
inside of a pattern because their types weren't recorded in
constraint system.
Resolves: rdar://80797176