[Incremental Imports] Fix tests to avoid priors modTime changes #38356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
davidungar
changed the title
|
This seems to have regressed the Windows VS2017 CI: https://ci-external.swift.org/job/oss-swift-windows-x86_64/8019/ The bash expansion isn't actually portable (it's unclear to me how the VS2019 build is getting away with this). Could you please look into this or revert the change? |
compnerd
added a commit
that referenced
this pull request
Jul 20, 2021
PR #38356 regressed the Windows (2017) CI. This attempts to remove the bashisms from the test to repair the test on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new safeguard for incremental imports relies on the mod-time of the priors being consistent with that in the build record.
Update the tests to work with that safeguard.
fixes rdar://80485272