test: attempt to repair the test on Windows #38505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #38356 regressed the Windows (2017) CI. This attempts to remove the bashisms from the test to repair the test on Windows.
|
CC: @drodriguez |
|
@swift-ci please smoke test |
drodriguez
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
Thanks. I had it in my radar, but I haven't had a lot of time lately. This is basically what I was thinking. I did a quick grep, and there are more examples. I wanted to figure out why this one (precisely) was changing. I know that Lit itself does a little bit of the globbing expansion, and I wonder if it was actually failing there or not.
Anyway, if this removes the problem for a while, it is welcome.
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #38356 regressed the Windows (2017) CI. This attempts to remove the bashisms from the test to repair the test on Windows.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.