Skip to content

Make ThrowingTaskGroup.nextResult() non-throwing. #38771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DougGregor
Copy link
Member

We erroneously marked this API as throws, even though it returns its
error via a Result instead. Remove the throws in a strange-looking
manner so that we maintain the existing ABI.

Fixes rdar://81585954.

We erroneously marked this API as `throws`, even though it returns its
error via a `Result` instead. Remove the `throws` in a strange-looking
manner so that we maintain the existing ABI.

Fixes rdar://81585954.
@ktoso ktoso self-requested a review August 6, 2021 00:00
@DougGregor
Copy link
Member Author

@swift-ci please smoke test and merge

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa awesome, Doug saves the day once again 👏
Thanks a lot!

@DougGregor
Copy link
Member Author

@swift-ci please smoke test Linux

@DougGregor DougGregor merged commit 6b72c82 into swiftlang:main Aug 6, 2021
@DougGregor DougGregor deleted the task-group-non-throwing-next-result branch August 6, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants