Make ThrowingTaskGroup.nextResult() non-throwing.
#38772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We erroneously marked this API as `throws`, even though it returns its error via a `Result` instead. Remove the `throws` in a strange-looking manner so that we maintain the existing ABI. Fixes rdar://81585954.
|
@swift-ci please test |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: We erroneously marked
ThrowingTaskGroup.nextResult()asthrows, even though it returns its error via aResultinstead. Remove thethrowsin a strange-looking manner so that we maintain the existing ABI.Scope: Affects new code using Swift's Concurrency model that uses task groups.
Radar/SR Issue: rdar://81585954.
Risk: Low.
Reviewed By: Konrad Malawski
Testing: PR testing and CI on main, including new tests.
Original PR: #38771