[Test] Added for call-as-async Optional<NS_EXTENSIBLE_STRING_ENUM>. #38786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
Previously, the function emitCBridgedToNativeValue handled three situations around optionals: - Bridged?, Native? - Bridged, Native? - Bridged, Native Here, handling for the fourth case - Bridged?, Native is added. To enable this, the number of Optional wrappings that the bridged type has that the native type does not is passed in to the function. Then, in the portions of the function where actual transformations are done, the values are unwrapped an appropriate number of times. Mostly that means force unwrapping N times before doing the transformation. In the case of types that conform to _ObjectiveCBridgeable, however, it means force unwrapping the value N-1 times after doing the transformation because _ObjectiveCBridgeable._unconditionallyBridgeFromObjectiveC performs one layer of unwrapping itself. rdar://81590807
The underlying problem was fixed by the change for rdar://81590807 . Add tests for the specific case that was originally reported. rdar://80704382
nate-chandler
force-pushed
the
rdar80704382
branch
from
4e518fc to
03e175a
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please clean test macos platform |
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Aug 25, 2021
[Test] Added for call-as-async Optional<NS_EXTENSIBLE_STRING_ENUM>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying problem was fixed by the change for rdar://81590807 . Add tests
for the specific case that was originally reported.
Requires #38773 .
rdar://80704382