[SILGen] Handled transforming Bridged? -> Swift. #38773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
rdar81590807
branch
2 times, most recently
from
d01cec7 to
ba7ddb0
Compare
|
@swift-ci please test |
This was referenced Aug 6, 2021
|
Hm, does this defeat the special handling of null bridging for types like NSString, where we intentionally map nil to empty |
nate-chandler
force-pushed
the
rdar81590807
branch
from
ba7ddb0 to
2fecfe1
Compare
|
@swift-ci please test |
nate-chandler
changed the title
Previously, the function emitCBridgedToNativeValue handled three situations around optionals: - Bridged?, Native? - Bridged, Native? - Bridged, Native Here, handling for the fourth case - Bridged?, Native is added. To enable this, the number of Optional wrappings that the bridged type has that the native type does not is passed in to the function. Then, in the portions of the function where actual transformations are done, the values are unwrapped an appropriate number of times. Mostly that means force unwrapping N times before doing the transformation. In the case of types that conform to _ObjectiveCBridgeable, however, it means force unwrapping the value N-1 times after doing the transformation because _ObjectiveCBridgeable._unconditionallyBridgeFromObjectiveC performs one layer of unwrapping itself. rdar://81590807
nate-chandler
force-pushed
the
rdar81590807
branch
from
2fecfe1 to
6eb4f2c
Compare
nate-chandler
changed the title
|
@swift-ci please test |
|
(For cross-referencing purposes, the behavior was changed in a force-push to preserve the behavior of incorrectly nil NSStrings; that behavior is tested at https://github.com/apple/swift/pull/38773/files#diff-154a8dcf6adb593e4e77f29be44041d0ccc9ef9546fd0ef6bdb56dcb51119d87R34 .) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the function emitCBridgedToNativeValue handled three situations around optionals:
Here, handling for the fourth case
is added.
To enable this, the number of Optional wrappings that the bridged type has that the native type does not is passed in to the function. Then, in the portions of the function where actual transformations are done, the values are unwrapped an appropriate number of times. Mostly that means force unwrapping N times before doing the transformation. In the case of types that conform to _ObjectiveCBridgeable, however, it means force unwrapping the value N-1 times after doing the transformation because _ObjectiveCBridgeable._unconditionallyBridgeFromObjectiveC performs one layer of unwrapping itself.
rdar://81590807