[Refactoring] Fix invalid legacy body for Result<Void, ...> handler #38855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ahoppen
approved these changes
Aug 12, 2021
Good point, I didn't even notice that we weren't. I assume the majority of these were added before it existed? I'll convert these now in a separate commit (and put the unrelated _ change with it). |
bnbarham
force-pushed
the
async-refactoring-void-result
branch
2 times, most recently
from
e3f99c5 to
3ab7862
Compare
When adding an async alternative for a function with a `(Result<Void, ...>) -> Void` completion handler, the legacy body was adding a call to the handler with `.success(result)`. We don't assign to `result` for `Void` handlers, so pass `()` instead. Resolves rdar://81829392
bnbarham
force-pushed
the
async-refactoring-void-result
branch
from
3ab7862 to
46a4b24
Compare
|
Updated all the tests in convert_function.swift to compile as well. Changed them all to -convert-to-async since none are checking the legacy body. Also noticed that we already had the |
Update the async refactoring tests in `convert_function.swift` to compile the refactored code (where possible) to check for errors. This would have prevented the issue with the refactored `Result<Void, ...`> handler producing erroneous code.
bnbarham
force-pushed
the
async-refactoring-void-result
branch
from
46a4b24 to
9fc758a
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding an async alternative for a function with a
(Result<Void, ...>) -> Voidcompletion handler, the legacy body was adding a call tothe handler with
.success(result). We don't assign toresultforVoid handlers, so pass
()instead.Resolves rdar://81829392