[5.5][Refactoring] Fix invalid legacy body for Result<Void, ...> handler #38865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eed to be unwrapped after refactoring Throw another `getSemanticsProvidingExpr` in the async refactoring code for better results.
When adding an async alternative for a function with a `(Result<Void, ...>) -> Void` completion handler, the legacy body was adding a call to the handler with `.success(result)`. We don't assign to `result` for `Void` handlers, so pass `()` instead. Resolves rdar://81829392
Update the async refactoring tests in `convert_function.swift` to compile the refactored code (where possible) to check for errors. This would have prevented the issue with the refactored `Result<Void, ...`> handler producing erroneous code.
|
@swift-ci please test |
akyrtzi
approved these changes
Aug 16, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #38665 and #38855