[Distributed] Only parse distributed when experimental mode enabled #38889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
|
@swift-ci please smoke test |
ktoso
commented
Aug 16, 2021
kavon
reviewed
Aug 16, 2021
Comment on lines
+1614
to
+1621
| // If this attribute is only permitted when distributed is enabled, reject it. | ||
| if (DeclAttribute::isDistributedOnly(DK) && | ||
| !shouldParseExperimentalDistributed()) { | ||
| diagnose(Loc, diag::attr_requires_distributed, AttrName, | ||
| DeclAttribute::isDeclModifier(DK)); | ||
| DiscardAttribute = true; | ||
| } | ||
|
|
There was a problem hiding this comment.
I feel like this is the only thing that's actually needed to solve the issue. Everything else is just for availability things.
There was a problem hiding this comment.
I'll remove the availability support from this PR, thanks
kavon
reviewed
Aug 16, 2021
| @@ -24,6 +24,8 @@ constexpr static const StringLiteral STDLIB_NAME = "Swift"; | |||
| constexpr static const StringLiteral SWIFT_ONONE_SUPPORT = "SwiftOnoneSupport"; | |||
| /// The name of the Concurrency module, which supports that extension. | |||
| constexpr static const StringLiteral SWIFT_CONCURRENCY_NAME = "_Concurrency"; | |||
| /// The name of the Distributed module, which supports that extension. | |||
| constexpr static const StringLiteral SWIFT_DISTRIBUTED_NAME = "_Distributed"; | |||
There was a problem hiding this comment.
I thought the module is called Distributed right now, with no underscore. The underscore is for implicitly-imported modules I think.
There was a problem hiding this comment.
The import is _Distributed, same as _Concurrency was and it did have to be imported explicitly for a while.
ktoso
force-pushed
the
wip-distributed-only-exp
branch
from
52b0163 to
5617856
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't completely implement the guarding of
distributedin parsing, so it might have continued anyway, and fail when module types were needed.This now fails at compilation right away when distributed keyword is encountered but the experimental mode is not enabled.
Resolves rdar://81909966