[test] Use %refactor-check-compiles in more places #38915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
approved these changes
Aug 18, 2021
| // ERROR-BLOCK-COMMENT-NEXT: // h | ||
| // ERROR-BLOCK-COMMENT-NEXT: print("after") | ||
| // ERROR-BLOCK-COMMENT-NEXT: // i | ||
| // ERROR-BLOCK-COMMENT-NEXT: {{ }} |
There was a problem hiding this comment.
Why is there a newline here?
There was a problem hiding this comment.
It's because we include the trailing trivia up until the next token, but in this case the next token gets removed by the transform, leaving a stray newline. At the time, it didn't seem like a case that would come up too often, given it should only happen for trailing comments at the end of braces. Though looking at it again, it seems like it should be pretty straightforward to fix, filed rdar://82072147 to take care of it. Thanks for pointing it out!
This hidden frontend option lets us be more lax when type-checking in the presence of editor placeholders by treating them as holes during constraint solving.
This allows us to test more cases that type-check modulo placeholders.
Forward these flags to both swift-frontend and swift-refactor.
Update a bunch of async refactoring tests to use %refactor-check-compiles in more cases.
hamishknight
force-pushed
the
refactor-evaluate-print-loop
branch
from
c39889e to
f58c62c
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a hidden frontend flag
-warn-on-editor-placeholderthat allows%refactor-check-compilesto be more lenient with placeholders, and update a bunch of async refactoring tests to use%refactor-check-compilesin more cases.Note the diff is best viewed without whitespace.
rdar://81830915