[5.5] [test] Use %refactor-check-compiles in more places #39007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hamishknight |
`%build-clang-importer-objc-overlays` builds the overlays for the current target rather than the host, so update the `%refactor` invocations to take the target as an argument. rdar://81128571
This hidden frontend option lets us be more lax when type-checking in the presence of editor placeholders by treating them as holes during constraint solving.
This allows us to test more cases that type-check modulo placeholders.
Forward these flags to both swift-frontend and swift-refactor.
Update a bunch of async refactoring tests to use %refactor-check-compiles in more cases.
hamishknight
force-pushed
the
refactor-test-changes-5.5
branch
from
e0bf665 to
36d85f5
Compare
|
@swift-ci please test |
akyrtzi
approved these changes
Aug 24, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.5 cherry-pick of #37966, #38857 & #38915.
This is NFC, cherry-picking purely to avoid future merge conflicts in the event we pull more async refactoring changes into the 5.5 branch.
Add a hidden frontend flag
-warn-on-editor-placeholderthat allows%refactor-check-compilesto be more lenient with placeholders, and update a bunch of async refactoring tests to use%refactor-check-compilesin more cases.Note the diff is best viewed without whitespace.
rdar://81830915