Deserializer: call the deserialization callback when a new function declaration is created #38926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eclaration is created This makes sure that all analysis will get the `notifyAddedOrModifiedFunction` notifications. This fixes a crash in CallerAnalysis, which relies that it's notified for all newly created functions. This is related to following bug reports for cross-module-optimization: https://bugs.swift.org/browse/SR-15048 rdar://81701218 Although I believe that there are more bugs involved which need to be fixed. Unfortunately I don't have a test case for this fix.
|
@swift-ci test |
|
Build failed |
|
Build failed |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that all analysis will get the
notifyAddedOrModifiedFunctionnotifications.It fixes a crash in CallerAnalysis, which relies that it's notified for all newly created functions.
This is related to following bug reports for cross-module-optimization:
https://bugs.swift.org/browse/SR-15048
rdar://81701218
Although I believe that there are more bugs involved which need to be fixed.
Unfortunately I don't have a test case for this fix.