Skip to content

Deserializer: call the deserialization callback when a new function declaration is created #38926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Deserializer: call the deserialization callback when a new function declaration is created #38926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/Serialization/DeserializeSIL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,14 @@ SILFunction *SILDeserializer::getFuncForReference(StringRef name,
// SIL.
SourceLoc sourceLoc;
SILSerializationFunctionBuilder builder(SILMod);
return builder.createDeclaration(name, type, RegularLocation(sourceLoc));
fn = builder.createDeclaration(name, type,
RegularLocation(sourceLoc));
// The function is not really de-serialized, but it's important to call
// `didDeserialize` on every new function. Otherwise some Analysis might miss
// `notifyAddedOrModifiedFunction` notifications.
if (Callback)
Callback->didDeserialize(MF->getAssociatedModule(), fn);
return fn;
}

/// Helper function to find a SILFunction, given its name and type.
Expand Down