When building stdlib, pass -prespecialize-generic-metadata from CMake, and respect the flag in IRGenModule::shouldPrespecializeGenericMetadata #38946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
kubamracek
force-pushed
the
stdlib-prespecialization-from-cmake
branch
from
b899f63 to
b55a6c8
Compare
|
@swift-ci please test |
|
Build failed |
…, and respect the flag in IRGenModule::shouldPrespecializeGenericMetadata
kubamracek
force-pushed
the
stdlib-prespecialization-from-cmake
branch
from
b55a6c8 to
ed650c4
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
|
Was there a reason that Windows wasn't included in the default? |
Hey! No particular reason - but I think the old behavior (before the change) was that prespecialization was already disabled on Windows? See the condition in IRGenModule::shouldPrespecializeGenericMetadata. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.