Runtimes: support generic metadata prespecialization for all of Core #79188
Conversation
edymtt
requested review from
etcwilde,
compnerd and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
Runtimes/Core/CMakeLists.txt
Outdated
| @@ -103,6 +103,13 @@ option(SwiftCore_ENABLE_FILESYSTEM_SUPPORT "Build for systems that have a filesy | |||
| option(SwiftCore_ENABLE_OS_TRACE_LAZY_INIT "Use os_trace call to check if lazy init has been completed before making os_signpost calls." ${SwiftCore_HAS_OS_TRACE}) | |||
| option(SwiftCore_HAS_DARWIN_LIBMALLOC "Use Darwin malloc features" ${APPLE}) | |||
|
|
|||
| if("${APPLE}" OR "${LINUX}") | |||
There was a problem hiding this comment.
This is what cmake/modules/DefaultSettings.cmake is for.
"${APPLE}" should be APPLE and "${LINUX}" should be LINUX, but the ON cases can also just go under the appropriate platforms in DefaultSettings.cmake, and then use defaulted_option(SwiftCore_ENABLE_PRESPECIALIZATION "Enable generic metadata prespecialization") from this file.
Edit: default_set -> defaulted_option
There was a problem hiding this comment.
Thanks for the feedback, and sorry for not reading the code more thoroughly before hand -- this is addressed in f757406
edymtt
force-pushed
the
edymtt/apply-prespecialize-generic-metadata-to-all-of-core
branch
from
9cb5327 to
f757406
Compare
|
@swift-ci please smoke test |
|
Waiting for swiftlang/llvm-project#9970 to land before rekicking LInux tests |
edymtt
force-pushed
the
edymtt/apply-prespecialize-generic-metadata-to-all-of-core
branch
from
f757406 to
c33c8fc
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
Because I based my default on what the current code is doing, thinking it had a reasonable default worth preserving. Digging a bit deeper, that was done since at the time prespecialization was not supported for Windows -- since then the support has been added, but the CMake code has not been updated to reflect that (and I could not find that being overridden in Sorry for missing this context, I will amend this. |
Also provide a flag to enabled/disable it. Addresses rdar://144255917
edymtt
force-pushed
the
edymtt/apply-prespecialize-generic-metadata-to-all-of-core
branch
from
c33c8fc to
2a36723
Compare
|
@swift-ci please smoke test |
|
I need to rekick Windows testing when #79214 is merged |
|
@swift-ci please smoke test Windows |
Also provide a flag to enabled/disable it.
Addresses rdar://144255917