-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Runtimes: introduce SwiftOnoneSupport
#78726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtimes: introduce SwiftOnoneSupport
#78726
Conversation
@swift-ci please smoke test |
1bccfb4
to
2073907
Compare
2073907
to
bca4796
Compare
@swift-ci please smoke test |
The main goal for now is to have this building, with little concern about matching the build flags used currently. Keep it disabled by default on Apple platforms. Addresses rdar://143151393
bca4796
to
c1257eb
Compare
@swift-ci please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking for the missing flag, but it looks like there are ~1300 missing public symbols.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we're at least missing -Xfrontend -prespecialize-generic-metadata
. That doesn't seem to get all of the generic specializations back though so we're likely missing more.
I could comb through the CMake logic to find the missing flags, but it may be more efficient to ensure the stdlib build invoked with |
@swift-ci please smoke test |
@swift-ci please smoke test Linux |
@swift-ci please smoke test Windows |
From a macOS build at desk, it looks like the SwiftOnoneSupport built this way generates the same symbols as the one build the old way (except the magic install name symbols, since we are not setting
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed some bleeding whitespace
…Lists.txt Co-authored-by: Saleem Abdulrasool <[email protected]>
@swift-ci please smoke test |
The main goal for now is to have this building, with little concern about matching the build flags used currently.
Keep it disabled by default on Apple platforms.
Addresses rdar://143151393