ABIChecker: diagnose mangled name changes #39010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
ghost
approved these changes
Aug 23, 2021
Moving generic constraint from extension to its member or vice versa may change the mangled name of the member without changing the generic signature, thus introducing ABI breakages. This change teaches the ABI checker to diagnose USR (mangled name) changes to cover such cases. rdar://78276290
nkcsgexi
force-pushed
the
diff-demangled
branch
from
81df905 to
d7f5dc4
Compare
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test Linux platform |
|
swiftlang/swift-driver#802 |
compnerd
added a commit
that referenced
this pull request
Aug 24, 2021
There is a reference to `std::string` being introduced without the necessary header being included. Add the missing include.
shahmishal
added a commit
that referenced
this pull request
Aug 24, 2021
AST: repair the build after #39010
nkcsgexi
pushed a commit
to nkcsgexi/swift
that referenced
this pull request
Aug 25, 2021
There is a reference to `std::string` being introduced without the necessary header being included. Add the missing include.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving generic constraint from extension to its member or vice versa may change the mangled name
of the member without changing the generic signature, thus introducing ABI breakages. This change
teaches the ABI checker to diagnose USR (mangled name) changes to cover such cases.
rdar://78276290