-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Support Xcode 13 beta 4 #39012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shahmishal
merged 8 commits into
release/5.5-08092021
from
support-xcode-13-beta4-5.5-08092021
Aug 24, 2021
Merged
Support Xcode 13 beta 4 #39012
shahmishal
merged 8 commits into
release/5.5-08092021
from
support-xcode-13-beta4-5.5-08092021
Aug 24, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move all ObjC array tests into a separate file ArraysObjc.swift.gyb * merge the remaining Arrays.swift.gyb and ArrayNew.swift.gyb files * move the utilities from ArrayTypesAndHelpers.swift into its only use into ArraysObjc.swift.gyb (cherry picked from commit 6f41929) (cherry picked from commit 703c354)
COW checking needs that all libraries are consistently compiled with asserts enabled. This is not the case for the Foundation overlay anymore. Therefore it does not work with some tests which interop with Foundation. The solution here is to disable COW checking by default, but enable it for Array tests which do not interop with Foundation. (cherry picked from commit 0831240) (cherry picked from commit 96e0cb4)
COW checking needs that all libraries are consistently compiled with asserts enabled. This is not the case for the Foundation overlay anymore. Therefore it does not work with some tests which interop with Foundation. The solution here is to disable COW checking by default, but enable it for Array tests which do not interop with Foundation. (cherry picked from commit 0831240) (cherry picked from commit c13e531)
(cherry picked from commit 4d093f8)
(cherry picked from commit 250fd5f)
@swift-ci test |
kavon
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Build failed |
swiftlang/swift-driver#803 |
najacque
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.