Skip to content

Support Xcode 13 beta 4 #39012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 24, 2021

Conversation

shahmishal
Copy link
Member

No description provided.

shahmishal and others added 8 commits August 23, 2021 16:16
(cherry picked from commit 5363a80)
(cherry picked from commit 95201f0)
* move all ObjC array tests into a separate file ArraysObjc.swift.gyb
* merge the remaining Arrays.swift.gyb and ArrayNew.swift.gyb files
* move the utilities from ArrayTypesAndHelpers.swift into its only use into ArraysObjc.swift.gyb

(cherry picked from commit 6f41929)
(cherry picked from commit 703c354)
COW checking needs that all libraries are consistently compiled with asserts enabled. This is not the case for the Foundation overlay anymore.
Therefore it does not work with some tests which interop with Foundation.

The solution here is to disable COW checking by default, but enable it for Array tests which do not interop with Foundation.

(cherry picked from commit 0831240)
(cherry picked from commit 96e0cb4)
COW checking needs that all libraries are consistently compiled with asserts enabled. This is not the case for the Foundation overlay anymore.
Therefore it does not work with some tests which interop with Foundation.

The solution here is to disable COW checking by default, but enable it for Array tests which do not interop with Foundation.

(cherry picked from commit 0831240)
(cherry picked from commit c13e531)
Earlier, I accidentally marked Arrays.swift.gyb, however the test that
is failing is ArraysObjc.swift.gyb.

(cherry picked from commit c53d0eb)
(cherry picked from commit 5343fdc)
(cherry picked from commit 4d093f8)
Stopped validation-test/compiler_crashers_2_fixed/rdar79383990.swift
from trying to call -[NSBackgroundActivityScheduler scheduleWithBlock:]
async--that method is now annotated NS_SWIFT_DISABLE_ASYNC.

(cherry picked from commit 4a8a647)
(cherry picked from commit bdbf76a)
@shahmishal shahmishal requested a review from a team as a code owner August 23, 2021 23:21
@shahmishal
Copy link
Member Author

@swift-ci test

Copy link
Member

@kavon kavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d5bfa37

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#803
@swift-ci test macOS

@shahmishal shahmishal merged commit 1298714 into release/5.5-08092021 Aug 24, 2021
@shahmishal shahmishal deleted the support-xcode-13-beta4-5.5-08092021 branch August 24, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants