[Sema] Build TRC for delayed functions bodies #39064
Conversation
We used to build the full TypeRefinementContext of a source file before parsing delayed function bodies. This can lead to availability checking errors in delayed function bodies as the TRCs are incomplete. Complete the TRC of each delayed function before type-checking them to fix this. rdar://82269657
|
@swift-ci Please smoke test |
| // RUN: %target-swift-frontend -typecheck -dump-type-refinement-contexts %s -target x86_64-apple-macos10.12 | ||
| // RUN: %target-swift-frontend -typecheck -dump-type-refinement-contexts %s -target x86_64-apple-macos10.12 -experimental-skip-non-inlinable-function-bodies | ||
| // RUN: %target-swift-frontend -typecheck -dump-type-refinement-contexts %s -target x86_64-apple-macos10.12 -experimental-skip-non-inlinable-function-bodies-without-types | ||
| // RUN: %target-swift-frontend -typecheck -dump-type-refinement-contexts %s -target x86_64-apple-macos10.12 -experimental-skip-all-function-bodies |
There was a problem hiding this comment.
Is it worth checking the dumped contexts to make sure they aren't built in the skip-all (for all) and skip-non-inlinable (for funcWithType) cases?
There was a problem hiding this comment.
Why not, it's a somewhat reliable way to detect if those functions were type-checked or not. I've added this check as a new commit!
There was a problem hiding this comment.
Would it be possible to remove TypeChecker::getOrBuildTypeRefinementContext as well? There's only a single call in TypeChecker::overApproximateAvailabilityAtLocation and I believe that one can just assume it's built. getOrBuild seems somewhat unsafe since it doesn't handle delayed functions.
Would the refinement context for a delayed Decl ever be needed while typechecking a different Decl? Ie. should we ensure all contexts have been built prior to doing any typechecking?
LGTM otherwise
|
@swift-ci Please smoke test |
|
I think |
The compiler builds the full TypeRefinementContext of a source file before parsing delayed function bodies. This can lead to availability checking errors in delayed function bodies as the TRCs are incomplete.
Make sure we complete the TRC of each delayed function before type-checking them.
rdar://82269657