[5.5][Sema] Build TRC for delayed functions to fix availability issues in emit-module-separately #39081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
We used to build the full TypeRefinementContext of a source file before parsing delayed function bodies. This can lead to availability checking errors in delayed function bodies as the TRCs are incomplete. Complete the TRC of each delayed function before type-checking them to fix this. rdar://82269657
xymus
force-pushed
the
rdar82269657-5.5
branch
from
444f6eb to
28945da
Compare
|
@swift-ci Please test |
artemcm
approved these changes
Aug 30, 2021
airspeedswift
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #39064.
Fix an issue where
if #available(...)conditions may be ignored in emit-module-separately builds or when skipping non-inlinable function bodies.The compiler builds the full
TypeRefinementContextof a source file before parsing delayed function bodies. This can lead to availability checking errors in delayed function bodies as the TRCs are incomplete. Make sure we complete the TRC of each delayed function before type-checking them.rdar://82269657