Skip to content

benchmarks: Fix an integer overflow problem in the MapReduce benchmarks on 32-bit targets #39396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

eeckstein
Copy link
Contributor

No description provided.

@eeckstein
Copy link
Contributor Author

@swift-ci benchmark

@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

@swift-ci
Copy link
Contributor

Performance (x86_64): -O

Regression OLD NEW DELTA RATIO
MapReduceAnyCollection 87 124 +42.5% 0.70x

Code size: -O

Performance (x86_64): -Osize

Regression OLD NEW DELTA RATIO
MapReduceLazyCollectionShort 32 47 +46.9% 0.68x
FlattenListLoop 956 1404 +46.9% 0.68x (?)
FlattenListFlatMap 2630 3155 +20.0% 0.83x (?)
 
Improvement OLD NEW DELTA RATIO
ArrayAppendGenericStructs 1550 590 -61.9% 2.63x (?)
MapReduceString 44 41 -6.8% 1.07x (?)

Code size: -Osize

Performance (x86_64): -Onone

Improvement OLD NEW DELTA RATIO
ArrayAppendGenericStructs 1530 1250 -18.3% 1.22x (?)
NSError 472 437 -7.4% 1.08x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: 6-Core Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@eeckstein eeckstein merged commit 0bcd012 into swiftlang:main Sep 23, 2021
@eeckstein eeckstein deleted the fix-overflow branch September 23, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants