[cxx-interop][nfc] Add a ClangImporter request zone. #39435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoecarver
requested review from
slavapestov,
hyp,
DougGregor,
egorzhdan,
guitard0g and
hamishknight
|
Thank you for the review @hamishknight! |
zoecarver
force-pushed
the
lazy-pt7-clang-importer-zone
branch
2 times, most recently
from
50997f0 to
9d5232d
Compare
|
@swift-ci please smoke test. |
zoecarver
commented
Sep 28, 2021
|
Any other review comments? OK if I land this? |
slavapestov
approved these changes
Sep 28, 2021
This is just the boilerplate for adding a request zone. I haven't actually added any requrests in this commit.
The whole file was indented by one space.
zoecarver
force-pushed
the
lazy-pt7-clang-importer-zone
branch
from
9d5232d to
d52973f
Compare
|
@swift-ci please smoke test and merge. |
|
@swift-ci please smoke test Linux. |
|
@swift-ci please test Windows. |
1 similar comment
|
@swift-ci please test Windows. |
|
This is a nfc patch. I've seen it pass on the Windows CI before. I'm just going to land it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the boilerplate for adding a request zone. I haven't actually added any requrests in this commit.