[nfc][cxx-interop] Add three requests ClangDirectLookupRequest, CXXNamespaceMemberLookup, and ClangRecordMemberLookup.
#39436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoecarver
requested review from
slavapestov,
rjmccall,
hyp,
beccadax,
DougGregor,
egorzhdan and
guitard0g
zoecarver
force-pushed
the
lazy-pt8-add-requests
branch
from
578ed9c to
df64825
Compare
zoecarver
force-pushed
the
lazy-pt8-add-requests
branch
from
df64825 to
0f86e25
Compare
…XNamespaceMemberLookup`, and `ClangRecordMemberLookup`. None of these requests are used, so this is a non-functional change.
zoecarver
force-pushed
the
lazy-pt8-add-requests
branch
from
0f86e25 to
737597d
Compare
zoecarver
changed the title
CXXNamespaceMemberLookup, and ClangRecordMemberLookup.ClangDirectLookupRequest, CXXNamespaceMemberLookup, and ClangRecordMemberLookup.
|
Friendly ping. I'd love to get a review of this :) |
|
@swift-ci please smoke test. |
|
@swift-ci please test Windows platform. |
|
@swift-ci please test Windows. |
|
(re-testing after re-branch.) @swift-ci please smoke test. |
beccadax
reviewed
Oct 12, 2021
zoecarver
added a commit
to zoecarver/swift
that referenced
this pull request
Oct 13, 2021
If possible, add imported members to the StructDecl's LookupTable rather than adding them directly as members. This will fix the issues with ordering that swiftlang#39436 poorly attempted to solve during IRGen. This also allows us to break out most of the test changes from swiftlang#39436.
No, it's not. It gets used in #38675. I pulled it out because I thought it would be easier to review. Anyway, it's now merged back into #38675. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these requests are used, so this is a non-functional change.
Based on #39435. Please do not review the first commit, just click on the second commit and review that one. If you have comments on the first commit, please put them in #39435.
Refs #38675.