Skip to content

Add Builtin.print_disabled() #39698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kubamracek
Copy link
Contributor

The motivation here is to be able to give the stdlib a new print() API that will be marked @_alwaysEmitIntoClient and would have the ability to remove/silence all printing/logging via a compile-time switch on the client side. This is useful for code where logging is considered sensitive, and production builds want to be able to turn it all off.

@kubamracek kubamracek requested a review from eeckstein October 12, 2021 01:12
@kubamracek
Copy link
Contributor Author

CC @Catfish-Man

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 64b7c4f

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 64b7c4f

@kubamracek
Copy link
Contributor Author

Abandoning in favor of #39797.

@kubamracek kubamracek closed this Oct 20, 2021
@kubamracek kubamracek deleted the disable-print-builtin branch October 20, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants