[SILInliner] Only guaranteed args get lexical lifetimes. #39712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when inlining, both owned and guaranteed arguments were wrapped in lexical lifetimes before using them to within inlined callees. That is redundant, however, because SILGen add lexical lifetimes for owned arguments within functions. Here, the redundancy is removed by only adding lexical lifetimes for guaranteed arguments that are passed to inlined callees.
|
@swift-ci please test |
nate-chandler
deleted the
lexical_lifetimes/only-give-guaranteed-args-lexical-lifetimes-during-inlining
branch
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
Oct 15, 2021
Previously, after swiftlang#39712, lexical lifetimes were added for arguments whose parameter convention was guaranteed. Those lexical borrow scopes were added regardless of the ownership of the values which were passed as those arguments. Here, the lifetimes are only added for argument values which have ownership.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when inlining, both owned and guaranteed arguments were wrapped in lexical lifetimes before using them within inlined callees. That is redundant, however, because SILGen add lexical lifetimes for owned arguments within functions. Here, the redundancy is removed by only adding lexical lifetimes for guaranteed arguments that are passed to inlined callees.