[SILInliner] Only lifetime args with ownership. #39722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
lexical_lifetimes/only-owned-or-guaranteed-arg-conventions-when-inlining
branch
from
35c6a73 to
50198f8
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please clean test linux platform |
atrick
approved these changes
Oct 14, 2021
nate-chandler
force-pushed
the
lexical_lifetimes/only-owned-or-guaranteed-arg-conventions-when-inlining
branch
from
50198f8 to
062cd75
Compare
|
@swift-ci please smoke test and merge |
Previously, after swiftlang#39712, lexical lifetimes were added for arguments whose parameter convention was guaranteed. Those lexical borrow scopes were added regardless of the ownership of the values which were passed as those arguments. Here, the lifetimes are only added for argument values which have ownership.
nate-chandler
force-pushed
the
lexical_lifetimes/only-owned-or-guaranteed-arg-conventions-when-inlining
branch
from
062cd75 to
09dd182
Compare
|
@swift-ci please smoke test and merge |
nate-chandler
deleted the
lexical_lifetimes/only-owned-or-guaranteed-arg-conventions-when-inlining
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, after #39712, lexical lifetimes were added for arguments whose parameter convention was guaranteed. Those lexical borrow scopes were added regardless of the ownership of the argument values. Here, the lifetimes are only added for argument values whose ownership is owned or guaranteed.