[Protocol Metadata] Create protocol metadata using WeakAnyLinkage to avoid duplication #39944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
I think we also should match the visibility by setting it to hidden. |
|
@swift-ci Please smoke test |
|
@swift-ci please smoke test linux |
|
@swift-ci test Linux platform |
|
@swift-ci Please test macOS |
|
Build failed |
|
@swift-ci test |
|
Build failed |
|
@swift-ci please smoke test |
|
@swift-ci Please test |
|
Build failed |
…avoid duplication
|
@swift-ci please smoke test |
|
@swift-ci Please test |
aschwaighofer
added a commit
to aschwaighofer/swift
that referenced
this pull request
Dec 2, 2021
…c metadata This extends swiftlang#39944 to apply to more objc metadata. rdar://85037490
aschwaighofer
added a commit
to aschwaighofer/swift
that referenced
this pull request
Dec 10, 2021
…c metadata This extends swiftlang#39944 to apply to more objc metadata. rdar://85037490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that some SWIFT binaries show duplicate metadata entries such as __PROTOCOL_NSObject along with all descending linked metadata.
The Issue is that the protocol global is created with internal linkage. Because of the internal linkage, the linker will not merge identical records in the final output.
The fix is to update the linkage type to WeakAnyLinkage, same as in ObjC.
Also, from review feedback, we also match the visibility with ObjC visibility(GlobalValue::HiddenVisibility);
Resolves SR-15376.