[swift-stdlib-tool] use correct path when codesigning #40086
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keith does this look right to you? |
|
cc @DougGregor |
keith
approved these changes
Nov 8, 2021
|
|
@swift-ci please smoke test |
|
@CodaFi @DougGregor is it possible to get this one merged before Xcode 13.2 ships? Or did we already miss the cutoff? |
|
I'm afraid this missed the cutoff, yes. Apologies for not replying sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the path used when codesigning bundled Swift stdlib dylibs. It looks like this was missed in #40026.
swiftLibsare now absolute paths to Swift dylibs instead of library names, so we need to construct the destination path using the filename only.