Skip to content

[swift-stdlib-tool] use correct paths when codesigning #40093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

rmaz
Copy link
Contributor

@rmaz rmaz commented Nov 8, 2021

This PR fixes the destination path when codesigning with swift-stdlib-tool. There were also 3 cases of inverted logic that needed fixing.

Equivalent swift/5.5 PR is #40086

@rmaz
Copy link
Contributor Author

rmaz commented Nov 8, 2021

@keith

@keith
Copy link
Member

keith commented Nov 8, 2021

cc @salinas-miguel @CodaFi since part of this regressed in #39216

Copy link
Contributor

@salinas-miguel salinas-miguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these bugs

@CodaFi
Copy link
Contributor

CodaFi commented Nov 8, 2021

Thank you

@swift-ci test

@drodriguez drodriguez merged commit 415f546 into swiftlang:main Nov 9, 2021
@rmaz rmaz deleted the swift_stdlib_tool_main_fix branch November 9, 2021 15:22
@rmaz
Copy link
Contributor Author

rmaz commented Nov 9, 2021

@CodaFi any idea who to ping about getting #40086 approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants