Skip to content

[SyntaxBuilder] Make String conform to ExpressibleAs protocols #40128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Nov 10, 2021

@kimdv kimdv force-pushed the kimdv/conform-string-to-expressible-as-protocols branch from 164d467 to 2de9026 Compare November 10, 2021 21:32
@kimdv kimdv force-pushed the kimdv/conform-string-to-expressible-as-protocols branch from 2de9026 to b2e2c24 Compare November 12, 2021 09:20
@ahoppen
Copy link
Member

ahoppen commented Nov 12, 2021

swiftlang/swift-syntax#335

@swift-ci Please smoke test

@ahoppen ahoppen self-assigned this Nov 12, 2021
@kimdv kimdv force-pushed the kimdv/conform-string-to-expressible-as-protocols branch 2 times, most recently from f89efa5 to ff3f556 Compare November 15, 2021 17:31
@ahoppen
Copy link
Member

ahoppen commented Nov 16, 2021

swiftlang/swift-syntax#335

@swift-ci Please smoke test

@kimdv kimdv force-pushed the kimdv/conform-string-to-expressible-as-protocols branch 2 times, most recently from fcec336 to 3891704 Compare November 17, 2021 12:32
@kimdv kimdv requested a review from ahoppen November 17, 2021 12:38
@kimdv kimdv force-pushed the kimdv/conform-string-to-expressible-as-protocols branch from 3891704 to 6cafe7c Compare November 17, 2021 12:39
@ahoppen
Copy link
Member

ahoppen commented Nov 17, 2021

swiftlang/swift-syntax#335

@swift-ci Please smoke test

@@ -4,12 +4,20 @@
'MemberDeclListItem',
'SyntaxBuildable'
],
'StmtBuildable': [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made then in alphabetical order so it's easier to find them.
Would you mind to verify that?

@kimdv kimdv merged commit 9099fe9 into swiftlang:main Nov 17, 2021
@kimdv kimdv deleted the kimdv/conform-string-to-expressible-as-protocols branch November 17, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants