Make String conform to ExpressibleAs protocols
#335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Nov 11, 2021
|
@swift-ci Please test |
kimdv
changed the title
String conform to ExpressibleAs protocolsString conform to ExpressibleBy protocols
|
Will update code and rebase when #337 is merged |
kimdv
force-pushed
the
kimdv/conform-string-to-expressible-as-protocols
branch
2 times, most recently
from
7fd2710 to
889c765
Compare
|
I have rebased this and swiftlang/swift#40128 |
Merged
|
@kimdv If you want, I would encourage you to request commit access to Swift (https://www.swift.org/contributing/#commit-access). I think you have accumulated more than the encouraged 5 non-trivial pull request by now. 😉 With commit access you’ll be able to trigger CI yourself. |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Will rebase when #334 is merged. |
kimdv
force-pushed
the
kimdv/conform-string-to-expressible-as-protocols
branch
3 times, most recently
from
9a134cc to
cfb7d95
Compare
kimdv
force-pushed
the
kimdv/conform-string-to-expressible-as-protocols
branch
from
cfb7d95 to
674431e
Compare
ahoppen
changed the title
String conform to ExpressibleBy protocolsString conform to ExpressibleAs protocols
ahoppen
approved these changes
Nov 17, 2021
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some ideas I got, while I was playing around with #331 .
Not sure if it's correct to make some if this assumptions I make in the StringConvenienceInitializers.swift?
I think we can make those assumptions because it is simple types.
But let me hear if there is anything!
The test cases are getting more and more clean and easy to read 🎉