Add ExtensionDecl test
#331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
commented
Nov 1, 2021
ahoppen
reviewed
Nov 5, 2021
Sources/SwiftSyntaxBuilder/IdentifierPatternConvenienceInitializers.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftSyntaxBuilder/SimpleTypeIdentifierConvenienceInitializers.swift
Outdated
Show resolved
Hide resolved
kimdv
force-pushed
the
kimdv/add-extension-test
branch
2 times, most recently
from
f61c0ae to
ffd8380
Compare
This was referenced Nov 10, 2021
kimdv
force-pushed
the
kimdv/add-extension-test
branch
16 times, most recently
from
ef898d7 to
c656f72
Compare
kimdv
force-pushed
the
kimdv/add-extension-test
branch
7 times, most recently
from
d9cb8d5 to
3ea1ad8
Compare
kimdv
commented
Dec 1, 2021
Sources/SwiftSyntaxBuilder/StringLiteralExprConvenienceInitializers.swift
Show resolved
Hide resolved
kimdv
commented
Dec 1, 2021
kimdv
commented
Dec 1, 2021
Sources/SwiftSyntaxBuilder/IdentifierPatternConvenienceInitializers.swift
Show resolved
Hide resolved
kimdv
commented
Dec 1, 2021
kimdv
commented
Dec 1, 2021
Sources/SwiftSyntaxBuilder/SimpleTypeIdentifierConvenienceInitializers.swift
Show resolved
Hide resolved
kimdv
force-pushed
the
kimdv/add-extension-test
branch
3 times, most recently
from
e8a540d to
88c716a
Compare
|
@ahoppen I think this is now at a point where it makes sense too review :) |
kimdv
commented
Dec 2, 2021
ahoppen
reviewed
Dec 3, 2021
kimdv
force-pushed
the
kimdv/add-extension-test
branch
2 times, most recently
from
9fb11fc to
1ccdecf
Compare
kimdv
force-pushed
the
kimdv/add-extension-test
branch
from
1ccdecf to
bfe458a
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
ahoppen
approved these changes
Dec 6, 2021
|
CI just got very unlucky with its checkout. It was started at exactly the same time that the PRs were merged and picked up #331 but not swiftlang/swift#40358. It should be fixed in the next build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ahoppen ! 👋
I have played a but around with SwiftSyntaxBuilder. Started with making a test case that should make something like the Tokens.swift.
Just to have something realistic.
Made a bunch of convenient API's and other small improvements.
This PR is a bit messy (a lot of changes and far from done). But I improve the API, and try different Idas when I think something can be done smarter or more clean.
How should I progress this?
Do you want PR's with small changes, and I keep rebasing this branch on main as they get merged or just one big PR here?
Depends on:
#335
#334