[SwiftSyntax] Add more types in protocol map #40358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
changed the title
kimdv
force-pushed
the
kimdv/add-more-types-in-protocol-map
branch
2 times, most recently
from
3ed66ba to
7305330
Compare
|
@swift-ci Please smoke test |
kimdv
force-pushed
the
kimdv/add-more-types-in-protocol-map
branch
from
7305330 to
030e129
Compare
|
@swift-ci Please smoke test |
ahoppen
approved these changes
Dec 6, 2021
ahoppen
reviewed
Dec 6, 2021
| @@ -14,6 +20,15 @@ | |||
| 'MemberDeclList': [ | |||
| 'MemberDeclBlock' | |||
| ], | |||
| 'FunctionCallExpr': [ | |||
| 'CodeBlockItem', | |||
There was a problem hiding this comment.
For a future PR: Would it make sense to add automatically conformances like ExpressibleAsFunctionCallExpr : ExpressibleAsExpr (just like we have FunctionCallExpr : ExprBuildable and then add ExpressibleAsExpr : ExpressibleAsCodeBlockItem? That way, we wouldn’t need to add conformances to ExpressibleAsCodeBlockItem for every expression node.
The same thing I just showed for expression also applies to statements.
This was referenced Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiftlang/swift-syntax#331