[SR-15562] [Sema] Do not consider warning fixes for non-augmenting fix recording #40480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucianoPAlmeida
force-pushed
the
SR-15562-fail-diag
branch
from
dbb53a4 to
85246bc
Compare
|
@swift-ci Please smoke test |
|
Thanks @xedin! |
|
Not yet, so this should make it no problem. |
|
Also, I'm wrong - it was - https://github.com/apple/swift/tree/release/5.6 so you'd have to cherry-pick. |
Ah ok, will do it then |
LucianoPAlmeida
pushed a commit
that referenced
this pull request
Dec 10, 2021
[SR-15562] [Sema] Do not consider warning fixes for non-augmenting fix recording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that for non-augmenting fixes(TreatRValueAsLValue) if there is already a fix recorded at that anchor or subexpr, this fix is not recorded. The problem in this case is since we move the checked cast warning diagnostics to fix format in #34980, warning fixes were also considered so a failure was being skipped which seems incorrect and it was causing the issue. Warning fixes should not be considered in that logic because this will cause this issue where a warning fix recorded makes it skip the recording of any error fix which may lead the solver in this state of not able to produce a diagnostic.
Resolves SR-15562.