[5.6][SR-15562] [Sema] Do not consider warning fixes for non-augmenting fix recording #40498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-diag [SR-15562] [Sema] Do not consider warning fixes for non-augmenting fix recording
|
@swift-ci Please test |
LucianoPAlmeida
changed the title
xedin
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick: #40480
Explanation:
Warning fixes recorded would make solver to skip recording non-augmenting error fixes if they had the same anchor or is anchored in a sub-expression, leaving the type checker in a state where it could not produce a diagnostic.
Scope: Limited to constraint solver diagnostics.
Main Branch PR: #40480
Resolves: SR-15562
Risk: Low
Reviewed By: @xedin
Testing: Regression tests added