Skip to content

Make Objective-C protocol metadata weak hidden #40486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aschwaighofer
Copy link
Contributor

This reapplies PR#40342 with a fix for category linker errors. We will now only apply weak linkage to PROTOCOL metadata.

This addresses rdar://86256970 and rdar://85037490.

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test source compatibility

@swift-ci
Copy link
Contributor

swift-ci commented Dec 9, 2021

Build failed
Swift Test Linux Platform
Git Sha - c23ca90d9a554d201d39299b9c14a8971cf7bb20

@swift-ci
Copy link
Contributor

swift-ci commented Dec 9, 2021

Build failed
Swift Test OS X Platform
Git Sha - c23ca90d9a554d201d39299b9c14a8971cf7bb20

@aschwaighofer aschwaighofer force-pushed the make_objc_protocol_metadata_weak_hidden branch from c23ca90 to fca4d07 Compare December 9, 2021 21:03
@aschwaighofer
Copy link
Contributor Author

@swift-ci test

@aschwaighofer
Copy link
Contributor Author

@swift-ci test source compatibility

@swift-ci
Copy link
Contributor

swift-ci commented Dec 9, 2021

Build failed
Swift Test OS X Platform
Git Sha - fca4d0723eb01abed4fd843e517200b9bdd65d31

…c metadata

This extends swiftlang#39944 to apply to more objc metadata.

rdar://85037490
…lying this to PROTOCOL related data

rdar://86256970
@aschwaighofer aschwaighofer force-pushed the make_objc_protocol_metadata_weak_hidden branch from fca4d07 to 0d3af14 Compare December 10, 2021 15:27
@aschwaighofer
Copy link
Contributor Author

@swift-ci test

@aschwaighofer
Copy link
Contributor Author

@swift-ci test source compat

@aschwaighofer
Copy link
Contributor Author

@swift-ci test windows

2 similar comments
@aschwaighofer
Copy link
Contributor Author

@swift-ci test windows

@aschwaighofer
Copy link
Contributor Author

@swift-ci test windows

@aschwaighofer
Copy link
Contributor Author

@swift-ci test source compat

@aschwaighofer aschwaighofer merged commit 8631376 into swiftlang:main Dec 14, 2021
aschwaighofer added a commit to aschwaighofer/swift that referenced this pull request Dec 14, 2021
…ly applying weak linkage to PROTOCOL related data

This adjusts PR#40342 with a fix for category linker errors. We will now only apply weak linkage to PROTOCOL metadata.

Cherry-pick of commits from swiftlang#40486.

rdar://86256970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants