[SourceKit] Enqueue SwiftASTConsumers async on a queue
#40493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
pr/enqueue-consumer-on-background-queue
branch
from
aed101e to
137d38a
Compare
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
pr/enqueue-consumer-on-background-queue
branch
from
137d38a to
3c866ae
Compare
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Dec 10, 2021
Enqueuing `SwiftASTConsumer`s might be expensive because `getBuildOperationForConsumer` consults the file system. Since all results from the AST build are processed asynchronously anyway, there’s no need to perform the enqueuing synchronously. rdar://86289703
ahoppen
force-pushed
the
pr/enqueue-consumer-on-background-queue
branch
from
3c866ae to
c90c7a2
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enqueuing
SwiftASTConsumers might be expensive becausegetBuildOperationForConsumerconsults the file system. Since all results from the AST build are processed asynchronously anyway, there’s no need to perform the enqueuing synchronously.rdar://86289703