[5.6][SourceKit] Enqueue SwiftASTConsumers async on a queue #40497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lding an AST The feature was never used and just complicated the implementation.
FileContents already contains the stamps.
We never need to have two copies of the same `FileContent` object, so we don’t need a copy constructor and can thus pass it on the stack again, instead of storing it on the heap.
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Enqueuing `SwiftASTConsumer`s might be expensive because `getBuildOperationForConsumer` consults the file system. Since all results from the AST build are processed asynchronously anyway, there’s no need to perform the enqueuing synchronously. rdar://86289703
ahoppen
force-pushed
the
pr-5.6/enqueue-consumer-on-background-queue
branch
from
c13d6cd to
b9379ae
Compare
|
@swift-ci Please test |
…ciated source file is reopened If a file isn’t opened with a `key.sourcefile` argument, we don’t store a snapshot for it. This could cause a crash when trying to consult its snapshot to see whether an AST can be reused for cursor info.
|
@swift-ci Please test |
akyrtzi
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #40493, #40339 and #40504 to
release/5.6.Enqueuing
SwiftASTConsumers might be expensive becausegetBuildOperationForConsumerconsults the file system. Since all results from the AST build are processed asynchronously anyway, there’s no need to perform the enqueuing synchronously.Also cherry-picks #40339 because #40493 depends on the fact that you can’t specify fixed snapshots to use when building an AST.
rdar://86289703