Skip to content

[5.6][SourceKit] Enqueue SwiftASTConsumers async on a queue #40497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 10, 2021
Merged

[5.6][SourceKit] Enqueue SwiftASTConsumers async on a queue #40497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
757ee55
[SourceKit] Remove ability to specify fixed snapshots to use when bui…
ahoppen Nov 30, 2021
eaf14ab
[SourceKit] Store FileContents in ASTBuildOperation instead of snapshots
ahoppen Dec 8, 2021
cbf42ee
[SourceKit] Don't store Stamps in ASTBuildOperation
ahoppen Dec 8, 2021
fd9b4ef
[SourceKit] Remove some dupliate computation of realpaths
ahoppen Nov 30, 2021
920878e
[SourceKit] Make FileContent non ref-counted
ahoppen Dec 8, 2021
1ec362c
[SourceKit] Improve memory cost function of ASTBuildOperation
ahoppen Dec 8, 2021
b9379ae
[SourceKit] Enqueue `SwiftASTConsumer`s async on a queue
ahoppen Dec 9, 2021
2e9bf34
[SourceKit] Fix a crash that occurred when a document without an asso…
ahoppen Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions test/SourceKit/Misc/no-crash-reopen-without-compiler-args.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
// RUN: %empty-directory(%t)
// RUN: %{python} %utils/split_file.py -o %t %s
// RUN: %sourcekitd-test \
// RUN: -json-request-path %t/1-open-without-sourcefile.json \
// RUN: == -json-request-path %t/2-close.json \
// RUN: == -json-request-path %t/3-reopen-without-compiler-args.json \
// RUN: == -json-request-path %t/4-cursor-info.json

// This used to crash with a nullptr dereference because we didn't store a
// snapshot in the FileContents of a.swift since it wasn't opened with a
// key.sourcefile argument.

// BEGIN 1-open-without-sourcefile.json
{
key.request: source.request.editor.open,
key.name: "/invalid/a.swift",
key.compilerargs: [
"/invalid/a.swift",
"/invalid/b.swift"
],
key.sourcetext: "",
key.enablesyntaxmap: 0,
key.enablesubstructure: 0,
key.enablediagnostics: 0
}
// BEGIN 2-close.json
{
key.request: source.request.editor.close,
key.name: "/invalid/a.swift"
}
// BEGIN 3-reopen-without-compiler-args.json
{
key.request: source.request.editor.open,
key.name: "/invalid/a.swift",
key.compilerargs: [
],
key.sourcetext: "",
key.enablesyntaxmap: 0,
key.enablesubstructure: 0,
key.enablediagnostics: 0
}
// BEGIN 4-cursor-info.json
{
key.request: source.request.cursorinfo,
key.compilerargs: [
"/invalid/a.swift",
"/invalid/b.swift"
],
key.offset: 0,
key.sourcefile: "/invalid/a.swift"
}
Loading