Synchronize adding a child task to a TaskGroup with parent task #40520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a task is adding adding new children to a task group, we need to synchronize with the task status record lock of the parent task that has the task group, to prevent races with concurrent cancellation and escalation. Radar-Id: rdar://problem/86311782
|
Resolves rdar://86311782 |
|
@swift-ci please smoke test |
ktoso
reviewed
Dec 11, 2021
ktoso
reviewed
Dec 11, 2021
stdlib/public/CompatibilityOverride/CompatibilityOverrideConcurrency.def
Show resolved
Hide resolved
ktoso
approved these changes
Dec 11, 2021
ktoso
added
the
concurrency
|
Failure was the unrelated from swiftpm that we fixed; rebuilding |
|
@swift-ci please smoke test |
Co-authored-by: Konrad `ktoso` Malawski <[email protected]>
|
@swift-ci please smoke test |
|
rdar://86311782 |
rokhinip
deleted the
rokhinip/synchronize-group-child-creation-and-cancellation
branch
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task is adding adding new children to a task group, we need to synchronize with the task status record lock of the parent task that has the task group, to prevent races with concurrent cancellation and escalation.
In the future, we'd probably want a lock for the TaskGroup itself and not have it be the group's parent task's status record lock but for now, this will get us the right functionality.
rdar://86311782