5.6 [Concurrency]: Cancellation of TaskGroup should not trigger cancel handler of parent task #40621
+83
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ktoso
approved these changes
Dec 18, 2021
|
Build failed |
|
Build failed |
handler of parent task that created the group Change comment in TaskGroup.swift to enforce that only parent task can call cancelAll on the group Add tests to verify mutating of task group in child tasks will fail Radar-Id: rdar://problem/86346865
rokhinip
force-pushed
the
rokhinip/86346865-taskgroup-cancellAll-cancellationHandler-5.6
branch
from
3b4c14d to
5e10d36
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
rokhinip
deleted the
rokhinip/86346865-taskgroup-cancellAll-cancellationHandler-5.6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make sure that cancelling a task group does not invoke cancellation handler of parent task that created the group.
Risk:
Low. This does what the cancelAll API said it would do and makes sure not to invoke client handlers when it shouldn't.
Reviewed by: @ktoso
Testing:
Tests added in PR to verify this.
Original PR:
#40562
Radar-Id: rdar://problem/86346865