Cancellation of TaskGroup should not trigger cancel handler of parent task #40562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ktoso
reviewed
Dec 15, 2021
test/Concurrency/Runtime/taskgroup_cancelAll_cancellationHandler.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Dec 15, 2021
test/Concurrency/Runtime/async_taskgroup_cancel_from_inside_child.swift
Outdated
Show resolved
Hide resolved
rokhinip
force-pushed
the
rokhinip/86346865-taskgroup-cancellAll-cancellationHandler
branch
from
3258b45 to
d8b0aef
Compare
|
@swift-ci please test |
ktoso
reviewed
Dec 15, 2021
|
LGTM once:
Thanks again for digging into this @rokhinip ! PS: You can just "smoke test" after the change is made, since the full test run takes ages and these are a small change 👍 |
|
Build failed |
|
@swift-ci please test |
rokhinip
force-pushed
the
rokhinip/86346865-taskgroup-cancellAll-cancellationHandler
branch
from
9f36f03 to
a680523
Compare
|
@swift-ci please test |
ktoso
reviewed
Dec 18, 2021
ktoso
approved these changes
Dec 18, 2021
rokhinip
force-pushed
the
rokhinip/86346865-taskgroup-cancellAll-cancellationHandler
branch
from
a680523 to
1fb7693
Compare
|
@swift-ci please smoke test and merge it |
handler of parent task that created the group Change comment in TaskGroup.swift to enforce that only parent task can call cancelAll on the group Add tests to verify mutating of task group in child tasks will fail Radar-Id: rdar://problem/86346865
rokhinip
force-pushed
the
rokhinip/86346865-taskgroup-cancellAll-cancellationHandler
branch
from
1fb7693 to
835f274
Compare
|
@swift-ci please smoke test and merge it |
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test macOS platform |
rokhinip
deleted the
rokhinip/86346865-taskgroup-cancellAll-cancellationHandler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that cancelling a task group does not invoke cancellation handler of parent task that created the group
Change comment in TaskGroup.swift such that only parent task can call cancelAll on the group
Add tests to verify mutating of task group in child tasks will fail
Radar-Id: rdar://problem/86346865