[FixCode] Add a fixit to help users migrate to Swift 3 name convention. #4058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n of enum cases. rdar://26887735 When users' referring to a enum case with a wrong name and we can find a correct enum case whose name differs from the wrong name only in capitalization, we replace the wrong name with the correct one.
|
@swift-ci test |
|
@swift-ci smoke test OS X platform |
|
@swift-ci smoke test OS X platform |
|
@swift-ci smoke test OS X platform |
| @@ -72,6 +72,9 @@ ERROR(could_not_find_value_member,none, | |||
| ERROR(could_not_find_type_member,none, | |||
| "type %0 has no member %1", (Type, DeclName)) | |||
|
|
|||
| ERROR(could_not_find_enum_case,none, | |||
| "enum type %0 has no case %1; do you mean %2", (Type, DeclName, DeclName)) | |||
There was a problem hiding this comment.
Nitpick: This should be did you mean.
There was a problem hiding this comment.
Good catch! I'm updating.
|
@swift-ci smoke test OS X platform |
1 task
phausler
pushed a commit
to phausler/swift
that referenced
this pull request
Aug 8, 2016
…n. (swiftlang#4058) * [FixCode] Add a fixit to help users migrate to Swift 3 name convention of enum cases. rdar://26887735 When users' referring to a enum case with a wrong name and we can find a correct enum case whose name differs from the wrong name only in capitalization, we replace the wrong name with the correct one. * Addressing Argyrios' code review comments. NFC * [test] Update existing test. * Grammatical polish suggested by @CodaFi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FixCode] Add a fixit to help users migrate to Swift 3 name convention of enum cases. rdar://26887735
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
…n of enum cases. rdar://26887735
When users' referring to a enum case with a wrong name and we can find a correct enum case whose name
differs from the wrong name only in capitalization, we replace the wrong name with the correct one.