[FixCode] Add a fixit to help users migrate to Swift 3 name convention. #4063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n. (#4058) * [FixCode] Add a fixit to help users migrate to Swift 3 name convention of enum cases. rdar://26887735 When users' referring to a enum case with a wrong name and we can find a correct enum case whose name differs from the wrong name only in capitalization, we replace the wrong name with the correct one. * Addressing Argyrios' code review comments. NFC * [test] Update existing test. * Grammatical polish suggested by @CodaFi.
|
@swift-ci smoke test OS X platform |
|
Re-running tests. Looks like CI had troubles cloning the repository. |
|
@swift-ci smoke test os x |
| DeclName memberName) { | ||
| if (!memberName.isSimpleName()) | ||
| return DeclName(); | ||
| if (!MetaTy->getInstanceType()->is<EnumType>()) |
There was a problem hiding this comment.
What about generic enums?
|
@swift-ci smoke test OS X platform |
|
@jrose-apple Feedback addressed! |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Explanation: Swift 3 introduces new name convention for enum cases, we add a fixit to help users who keep using the old name while the declaration has been updated to conform the new convention.
Risk: Low; mostly reusing our typo-correction diagnosis path.
Reviewed by: Argyrios
Testing: Regression test added.
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
…n. (#4058)
When users' referring to a enum case with a wrong name and we can find a correct enum case whose name
differs from the wrong name only in capitalization, we replace the wrong name with the correct one.